Commit cd529a46 authored Oct 16, 2006 by Mike Christie Committed by James Bottomley Oct 25, 2006

[SCSI] libiscsi: fix missed iscsi_task_put in xmit error path



from bhalevy@gmail.com:

It looks like change 652 to libiscsi.c added some dead code around line
670
                if (rc) {
                        spin_unlock_bh(&conn->session->lock);
                        goto again;
                }

since 5 lines above we goto again if (rc).

It looks like the previous if (rc) should go away if we want to put the
ctask before
breaking out of the while loop with "goto again" (see following patch).

Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>

parent 98644047

drivers/scsi/libiscsi.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -661,8 +661,6 @@ static int iscsi_data_xmit(struct iscsi_conn *conn)
		spin_unlock_bh(&conn->session->lock);

		rc = tt->xmit_cmd_task(conn, conn->ctask);
		if (rc)
		goto again;

		spin_lock_bh(&conn->session->lock);
		__iscsi_put_ctask(conn->ctask);

Admin message