Commit cd340703 authored Nov 21, 2019 by Marc Dionne Committed by Linus Torvalds Nov 22, 2019

afs: Fix possible assert with callbacks from yfs servers



Servers sending callback breaks to the YFS_CM_SERVICE service may
send up to YFSCBMAX (1024) fids in a single RPC.  Anything over
AFSCBMAX (50) will cause the assert in afs_break_callbacks to trigger.

Remove the assert, as the count has already been checked against
the appropriate max values in afs_deliver_cb_callback and
afs_deliver_yfs_cb_callback.

Fixes: 35dbfba3 ("afs: Implement the YFS cache manager service")
Signed-off-by: Marc Dionne <marc.dionne@auristor.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent cc079039

fs/afs/callback.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -312,7 +312,6 @@ void afs_break_callbacks(struct afs_server *server, size_t count,
		_enter("%p,%zu,", server, count);

		ASSERT(server != NULL);
		ASSERTCMP(count, <=, AFSCBMAX);

		/* TODO: Sort the callback break list by volume ID */

Admin message