Commit cd261496 authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Linus Torvalds
Browse files

checkpatch: warn if missing author Signed-off-by 

Print a warning if none of the Signed-off-by lines cover the patch author.

Non-ASCII quoted printable encoding in From: headers and (lack of) double
quotes are handled.  Split From: headers are not fully handled: only the
first part is compared.

[geert+renesas@glider.be: only encode UTF-8 quoted printable mail headers]
  Link: http://lkml.kernel.org/r/20180718145254.4770-1-geert+renesas@glider.be
Link: http://lkml.kernel.org/r/20180712100323.26684-1-geert+renesas@glider.be


Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Acked-by: default avatarJoe Perches <joe@perches.com>
Acked-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 33aa4597

scripts/checkpatch.pl

+25 −3
Original line number Diff line number Diff line
@@ -13,6 +13,7 @@ use POSIX; 
use File::Basename;

use Cwd 'abs_path';

use Term::ANSIColor qw(:constants);

use Encode qw(decode encode);



my $P = $0;

my $D = dirname(abs_path($P));
@@ -2236,6 +2237,8 @@ sub process { 


	our $clean = 1;

	my $signoff = 0;

	my $author = '';

	my $authorsignoff = 0;

	my $is_patch = 0;

	my $in_header_lines = $file ? 0 : 1;

	my $in_commit_log = 0;		#Scanning lines before patch
@@ -2518,10 +2521,24 @@ sub process { 
			}

		}



# Check the patch for a From:

		if (decode("MIME-Header", $line) =~ /^From:\s*(.*)/) {

			$author = $1;

			$author = encode("utf8", $author) if ($line =~ /=\?utf-8\?/i);

			$author =~ s/"//g;

		}



# Check the patch for a signoff:

		if ($line =~ /^\s*signed-off-by:/i) {

			$signoff++;

			$in_commit_log = 0;

			if ($author ne '') {

				my $l = $line;

				$l =~ s/"//g;

				if ($l =~ /^\s*signed-off-by:\s*\Q$author\E/i) {

				    $authorsignoff = 1;

				}

			}

		}



# Check if MAINTAINERS is being updated.  If so, there's probably no need to
@@ -6507,9 +6524,14 @@ sub process { 
		ERROR("NOT_UNIFIED_DIFF",

		      "Does not appear to be a unified-diff format patch\n");

	}

	if ($is_patch && $has_commit_log && $chk_signoff && $signoff == 0) {

	if ($is_patch && $has_commit_log && $chk_signoff) {

		if ($signoff == 0) {

			ERROR("MISSING_SIGN_OFF",

			      "Missing Signed-off-by: line(s)\n");

		} elsif (!$authorsignoff) {

			WARN("NO_AUTHOR_SIGN_OFF",

			     "Missing Signed-off-by: line by nominal patch author '$author'\n");

		}

	}



	print report_dump();

CRA Git | Maintained and supported by SUSTech CRA and CCSE