Commit cd11016e authored by Alexander Potapenko's avatar Alexander Potapenko Committed by Linus Torvalds
Browse files

mm, kasan: stackdepot implementation. Enable stackdepot for SLAB 



Implement the stack depot and provide CONFIG_STACKDEPOT.  Stack depot
will allow KASAN store allocation/deallocation stack traces for memory
chunks.  The stack traces are stored in a hash table and referenced by
handles which reside in the kasan_alloc_meta and kasan_free_meta
structures in the allocated memory chunks.

IRQ stack traces are cut below the IRQ entry point to avoid unnecessary
duplication.

Right now stackdepot support is only enabled in SLAB allocator.  Once
KASAN features in SLAB are on par with those in SLUB we can switch SLUB
to stackdepot as well, thus removing the dependency on SLUB stack
bookkeeping, which wastes a lot of memory.

This patch is based on the "mm: kasan: stack depots" patch originally
prepared by Dmitry Chernenkov.

Joonsoo has said that he plans to reuse the stackdepot code for the
mm/page_owner.c debugging facility.

[akpm@linux-foundation.org: s/depot_stack_handle/depot_stack_handle_t]
[aryabinin@virtuozzo.com: comment style fixes]
Signed-off-by: default avatarAlexander Potapenko <glider@google.com>
Signed-off-by: default avatarAndrey Ryabinin <aryabinin@virtuozzo.com>
Cc: Christoph Lameter <cl@linux.com>
Cc: Pekka Enberg <penberg@kernel.org>
Cc: David Rientjes <rientjes@google.com>
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Andrey Konovalov <adech.fo@gmail.com>
Cc: Dmitry Vyukov <dvyukov@google.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Konstantin Serebryany <kcc@google.com>
Cc: Dmitry Chernenkov <dmitryc@google.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent be7635e7

arch/x86/kernel/Makefile

+1 −0
Original line number Diff line number Diff line
@@ -19,6 +19,7 @@ endif 
KASAN_SANITIZE_head$(BITS).o				:= n

KASAN_SANITIZE_dumpstack.o				:= n

KASAN_SANITIZE_dumpstack_$(BITS).o			:= n

KASAN_SANITIZE_stacktrace.o := n



OBJECT_FILES_NON_STANDARD_head_$(BITS).o		:= y

OBJECT_FILES_NON_STANDARD_relocate_kernel_$(BITS).o	:= y

include/linux/stackdepot.h

0 → 100644
+32 −0
Original line number Diff line number Diff line 
/*

 * A generic stack depot implementation

 *

 * Author: Alexander Potapenko <glider@google.com>

 * Copyright (C) 2016 Google, Inc.

 *

 * Based on code by Dmitry Chernenkov.

 *

 * This program is free software; you can redistribute it and/or modify

 * it under the terms of the GNU General Public License as published by

 * the Free Software Foundation; either version 2 of the License, or

 * (at your option) any later version.

 *

 * This program is distributed in the hope that it will be useful,

 * but WITHOUT ANY WARRANTY; without even the implied warranty of

 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the

 * GNU General Public License for more details.

 *

 */



#ifndef _LINUX_STACKDEPOT_H

#define _LINUX_STACKDEPOT_H



typedef u32 depot_stack_handle_t;



struct stack_trace;



depot_stack_handle_t depot_save_stack(struct stack_trace *trace, gfp_t flags);



void depot_fetch_stack(depot_stack_handle_t handle, struct stack_trace *trace);



#endif

lib/Kconfig

+4 −0
Original line number Diff line number Diff line
@@ -536,4 +536,8 @@ config ARCH_HAS_PMEM_API 
config ARCH_HAS_MMIO_FLUSH

	bool



config STACKDEPOT

	bool

	select STACKTRACE



endmenu

lib/Kconfig.kasan

+1 −0
Original line number Diff line number Diff line
@@ -7,6 +7,7 @@ config KASAN 
	bool "KASan: runtime memory debugger"

	depends on SLUB_DEBUG || (SLAB && !DEBUG_SLAB)

	select CONSTRUCTORS

	select STACKDEPOT if SLAB

	help

	  Enables kernel address sanitizer - runtime memory debugger,

	  designed to find out-of-bounds accesses and use-after-free bugs.

lib/Makefile

+3 −0
Original line number Diff line number Diff line
@@ -181,6 +181,9 @@ obj-$(CONFIG_SG_SPLIT) += sg_split.o 
obj-$(CONFIG_STMP_DEVICE) += stmp_device.o

obj-$(CONFIG_IRQ_POLL) += irq_poll.o



obj-$(CONFIG_STACKDEPOT) += stackdepot.o

KASAN_SANITIZE_stackdepot.o := n



libfdt_files = fdt.o fdt_ro.o fdt_wip.o fdt_rw.o fdt_sw.o fdt_strerror.o \

	       fdt_empty_tree.o

$(foreach file, $(libfdt_files), \

CRA Git | Maintained and supported by SUSTech CRA and CCSE