Commit cd010d9b authored Aug 08, 2019 by Nishka Dasgupta Committed by Greg Kroah-Hartman Aug 15, 2019

sgi-xp: xpc_uv: Make structure xpc_arch_ops_uv constant



The static xpc_arch_operations structure xpc_arch_ops_uv is only copied
into the structure xpc_arch_ops, after which it is never modified; nor
is it used in any other way. Hence it can be declared as a constant to
prevent unintended modifications of its fields.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Acked-by: Robin Holt <robinmholt@gmail.com>
Link: https://lore.kernel.org/r/20190808080422.16503-1-nishkadg.linux@gmail.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 9bfe54e3

drivers/misc/sgi-xp/xpc_uv.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1678,7 +1678,7 @@ xpc_received_payload_uv(struct xpc_channel ch, void payload)
		XPC_DEACTIVATE_PARTITION(&xpc_partitions[ch->partid], ret);
		}

		static struct xpc_arch_operations xpc_arch_ops_uv = {
		static const struct xpc_arch_operations xpc_arch_ops_uv = {
		.setup_partitions = xpc_setup_partitions_uv,
		.teardown_partitions = xpc_teardown_partitions_uv,
		.process_activate_IRQ_rcvd = xpc_process_activate_IRQ_rcvd_uv,

Admin message