Commit cd006086 authored by Andy Whitcroft's avatar Andy Whitcroft Committed by Jeff Garzik
Browse files

ata_piix: defer disks to the Hyper-V drivers by default 

When we are hosted on a Microsoft Hyper-V hypervisor the guest disks
are exposed both via the Hyper-V paravirtualised drivers and via an
emulated SATA disk drive.  In this case we want to use the paravirtualised
drivers if we can as they are much more efficient.  Note that the Hyper-V
paravirtualised drivers only expose the virtual hard disk devices, the
CDROM/DVD devices must still be enumerated.

Mark the host controller ATA_HOST_IGNORE_ATA to prevent enumeration of
disk devices.

BugLink: http://bugs.launchpad.net/bugs/929545
BugLink: http://bugs.launchpad.net/bugs/942316


Signed-off-by: default avatarAndy Whitcroft <apw@canonical.com>
Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
parent db63a4c8

drivers/ata/ata_piix.c

+36 −0
Original line number Diff line number Diff line
@@ -1554,6 +1554,39 @@ static bool piix_broken_system_poweroff(struct pci_dev *pdev) 
	return false;

}



static int prefer_ms_hyperv = 1;

module_param(prefer_ms_hyperv, int, 0);



static void piix_ignore_devices_quirk(struct ata_host *host)

{

#if IS_ENABLED(CONFIG_HYPERV_STORAGE)

	static const struct dmi_system_id ignore_hyperv[] = {

		{

			/* On Hyper-V hypervisors the disks are exposed on

			 * both the emulated SATA controller and on the

			 * paravirtualised drivers.  The CD/DVD devices

			 * are only exposed on the emulated controller.

			 * Request we ignore ATA devices on this host.

			 */

			.ident = "Hyper-V Virtual Machine",

			.matches = {

				DMI_MATCH(DMI_SYS_VENDOR,

						"Microsoft Corporation"),

				DMI_MATCH(DMI_PRODUCT_NAME, "Virtual Machine"),

			},

		},

		{ }	/* terminate list */

	};

	const struct dmi_system_id *dmi = dmi_first_match(ignore_hyperv);



	if (dmi && prefer_ms_hyperv) {

		host->flags |= ATA_HOST_IGNORE_ATA;

		dev_info(host->dev, "%s detected, ATA device ignore set\n",

			dmi->ident);

	}

#endif

}



/**

 *	piix_init_one - Register PIIX ATA PCI device with kernel services

 *	@pdev: PCI device to register
@@ -1669,6 +1702,9 @@ static int __devinit piix_init_one(struct pci_dev *pdev, 
	}

	host->flags |= ATA_HOST_PARALLEL_SCAN;



	/* Allow hosts to specify device types to ignore when scanning. */

	piix_ignore_devices_quirk(host);



	pci_set_master(pdev);

	return ata_pci_sff_activate_host(host, ata_bmdma_interrupt, sht);

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE