Commit ccfc5693 authored Apr 05, 2020 by Petr Machata Committed by David S. Miller Apr 06, 2020

mlxsw: spectrum_flower: Do not stop at FLOW_ACTION_VLAN_MANGLE



The handler for FLOW_ACTION_VLAN_MANGLE ends by returning whatever the
lower-level function that it calls returns. If there are more actions lined
up after this action, those are never offloaded. Fix by only bailing out
when the called function returns an error.

Fixes: a150201a ("mlxsw: spectrum: Add support for vlan modify TC action")
Signed-off-by: Petr Machata <petrm@mellanox.com>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 0be0ae14

drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c

+6 −3

Original line number	Diff line number	Diff line
		@@ -150,9 +150,12 @@ static int mlxsw_sp_flower_parse_actions(struct mlxsw_sp *mlxsw_sp,
		u8 prio = act->vlan.prio;
		u16 vid = act->vlan.vid;

		return mlxsw_sp_acl_rulei_act_vlan(mlxsw_sp, rulei,
		err = mlxsw_sp_acl_rulei_act_vlan(mlxsw_sp, rulei,
		act->id, vid,
		proto, prio, extack);
		if (err)
		return err;
		break;
		}
		case FLOW_ACTION_PRIORITY:
		err = mlxsw_sp_acl_rulei_act_priority(mlxsw_sp, rulei,

Admin message