Commit ccf972bd authored Nov 21, 2009 by Pavel Machek Committed by Greg Kroah-Hartman Mar 03, 2010

Staging: dream: fix memory leak in camera error path



cppcheck found that ctrl_pmsm is leaked if the open operation fails.

Signed-off-by: Eric Sesterhenn <eric.sesterhenn@lsexperts.de>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent e79753ed

drivers/staging/dream/camera/msm_camera.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -1885,8 +1885,10 @@ static int msm_open_control(struct inode inode, struct file filep)
		return -ENOMEM;

		rc = msm_open_common(inode, filep, 0);
		if (rc < 0)
		if (rc < 0) {
		kfree(ctrl_pmsm);
		return rc;
		}

		ctrl_pmsm->pmsm = filep->private_data;
		filep->private_data = ctrl_pmsm;

Admin message