Commit ccf355e5 authored by Fuqian Huang's avatar Fuqian Huang Committed by David S. Miller
Browse files

net: phy: Make use of linkmode_mod_bit helper 



linkmode_mod_bit is introduced as a helper function to set/clear
bits in a linkmode.
Replace the if else code structure with a call to the helper
linkmode_mod_bit.

Signed-off-by: default avatarFuqian Huang <huangfq.daxian@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 88e2f284

drivers/net/phy/phy.c

+4 −12
Original line number Diff line number Diff line
@@ -298,12 +298,8 @@ int phy_ethtool_sset(struct phy_device *phydev, struct ethtool_cmd *cmd) 


	linkmode_copy(phydev->advertising, advertising);



	if (AUTONEG_ENABLE == cmd->autoneg)

		linkmode_set_bit(ETHTOOL_LINK_MODE_Autoneg_BIT,

				 phydev->advertising);

	else

		linkmode_clear_bit(ETHTOOL_LINK_MODE_Autoneg_BIT,

				   phydev->advertising);

	linkmode_mod_bit(ETHTOOL_LINK_MODE_Autoneg_BIT,

			 phydev->advertising, AUTONEG_ENABLE == cmd->autoneg);



	phydev->duplex = cmd->duplex;
@@ -353,12 +349,8 @@ int phy_ethtool_ksettings_set(struct phy_device *phydev, 


	linkmode_copy(phydev->advertising, advertising);



	if (autoneg == AUTONEG_ENABLE)

		linkmode_set_bit(ETHTOOL_LINK_MODE_Autoneg_BIT,

				 phydev->advertising);

	else

		linkmode_clear_bit(ETHTOOL_LINK_MODE_Autoneg_BIT,

				   phydev->advertising);

	linkmode_mod_bit(ETHTOOL_LINK_MODE_Autoneg_BIT,

			 phydev->advertising, autoneg == AUTONEG_ENABLE);



	phydev->duplex = duplex;

CRA Git | Maintained and supported by SUSTech CRA and CCSE