Commit ccd359f2 authored Sep 19, 2014 by Mitchel Humpherys Committed by Will Deacon Sep 22, 2014

iommu/arm-smmu: fix bug in pmd construction



We are using the same pfn for every pte we create while constructing the
pmd. Fix this by actually updating the pfn on each iteration of the pmd
construction loop.

It's not clear if we can actually hit this bug right now since iommu_map
splits up the calls to .map based on the page size, so we only ever seem to
iterate this loop once. However, things might change in the future that
might cause us to hit this.

Signed-off-by: Mitchel Humpherys <mitchelh@codeaurora.org>
Signed-off-by: Will Deacon <will.deacon@arm.com>

parent d3aba046

drivers/iommu/arm-smmu.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1408,6 +1408,7 @@ static int arm_smmu_alloc_init_pmd(struct arm_smmu_device smmu, pud_t pud,
		ret = arm_smmu_alloc_init_pte(smmu, pmd, addr, next, pfn,
		prot, stage);
		phys += next - addr;
		pfn = __phys_to_pfn(phys);
		} while (pmd++, addr = next, addr < end);

		return ret;

Admin message