Commit ccd34dac authored Jul 05, 2019 by Hou Zhiqiang Committed by Lorenzo Pieralisi Jul 08, 2019

PCI: mobiveil: Fix the valid check for inbound and outbound windows



In program_ib/ob_windows() check the window index from the function
parameter instead of the total number of initialized windows to
determine if the specified window is valid.

Fixes: 9af6bcb1 ("PCI: mobiveil: Add Mobiveil PCIe Host Bridge IP driver")
Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Reviewed-by: Minghuan Lian <Minghuan.Lian@nxp.com>
Reviewed-by: Subrahmanya Lingappa <l.subrahmanya@mobiveil.co.in>

parent ea0f1c95

drivers/pci/controller/pcie-mobiveil.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -458,7 +458,7 @@ static void program_ib_windows(struct mobiveil_pcie *pcie, int win_num,
		u32 value;
		u64 size64 = ~(size - 1);

		if ((pcie->ib_wins_configured + 1) > pcie->ppio_wins) {
		if (win_num >= pcie->ppio_wins) {
		dev_err(&pcie->pdev->dev,
		"ERROR: max inbound windows reached !\n");
		return;
		@@ -491,7 +491,7 @@ static void program_ob_windows(struct mobiveil_pcie *pcie, int win_num,
		{
		u64 size64 = ~(size - 1);

		if ((pcie->ob_wins_configured + 1) > pcie->apio_wins) {
		if (win_num >= pcie->apio_wins) {
		dev_err(&pcie->pdev->dev,
		"ERROR: max outbound windows reached !\n");
		return;

Admin message