Commit cc95b677 authored Feb 06, 2020 by Aurelien Aptel Committed by Steve French Feb 06, 2020

cifs: fix channel signing



The server var was accidentally used as an iterator over the global
list of connections, thus overwritten the passed argument. This
resulted in the wrong signing key being returned for extra channels.

Fix this by using a separate var to iterate.

Signed-off-by: Aurelien Aptel <aaptel@suse.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com>

parent d26c2ddd

fs/cifs/smb2transport.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -104,13 +104,14 @@ int smb2_get_sign_key(__u64 ses_id, struct TCP_Server_Info server, u8 key)
		{
		struct cifs_chan *chan;
		struct cifs_ses *ses = NULL;
		struct TCP_Server_Info *it = NULL;
		int i;
		int rc = 0;

		spin_lock(&cifs_tcp_ses_lock);

		list_for_each_entry(server, &cifs_tcp_ses_list, tcp_ses_list) {
		list_for_each_entry(ses, &server->smb_ses_list, smb_ses_list) {
		list_for_each_entry(it, &cifs_tcp_ses_list, tcp_ses_list) {
		list_for_each_entry(ses, &it->smb_ses_list, smb_ses_list) {
		if (ses->Suid == ses_id)
		goto found;
		}

Admin message