Commit cc9269f8 authored Jul 12, 2017 by Philipp Rosenberger Committed by Linus Walleij Aug 01, 2017

gpio: gpio-mxc: Fix: higher 16 GPIOs usable as wake source



In the function gpio_set_wake_irq(), port->irq_high is only checked for
zero. As platform_get_irq() returns a value less then zero if no interrupt
was found, any gpio >= 16 was handled like an irq_high interrupt was
available. On iMX27 for example no high interrupt is available. This lead
to the problem that only some gpios (the lower 16) were useable as wake
sources.

Signed-off-by: Philipp Rosenberger <p.rosenberger@linutronix.de>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent c23d200f

drivers/gpio/gpio-mxc.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -424,6 +424,9 @@ static int mxc_gpio_probe(struct platform_device *pdev)
		return PTR_ERR(port->base);

		port->irq_high = platform_get_irq(pdev, 1);
		if (port->irq_high < 0)
		port->irq_high = 0;

		port->irq = platform_get_irq(pdev, 0);
		if (port->irq < 0)
		return port->irq;

Admin message