Commit cc86432a authored May 21, 2020 by Valentin Schneider Committed by Marc Zyngier May 25, 2020

irqchip/gic-v2, v3: Drop extra IRQ_NOAUTOEN setting for (E)PPIs



(E)PPIs are per-CPU interrupts, so we want each CPU to go and enable them
via enable_percpu_irq(); this also means we want IRQ_NOAUTOEN for them as
the autoenable would lead to calling irq_enable() instead of the more
appropriate irq_percpu_enable().

Calling irq_set_percpu_devid() is enough to get just that since it trickles
down to irq_set_percpu_devid_flags(), which gives us IRQ_NOAUTOEN (and a
few others). Setting IRQ_NOAUTOEN *again* right after this call is just
redundant, so don't do it.

Signed-off-by: Valentin Schneider <valentin.schneider@arm.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20200521223500.834-1-valentin.schneider@arm.com

parent 9ed78b05

drivers/irqchip/irq-gic-v3.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -1282,7 +1282,6 @@ static int gic_irq_domain_map(struct irq_domain *d, unsigned int irq,
		irq_set_percpu_devid(irq);
		irq_domain_set_info(d, irq, hw, chip, d->host_data,
		handle_percpu_devid_irq, NULL, NULL);
		irq_set_status_flags(irq, IRQ_NOAUTOEN);
		break;

		case SPI_RANGE:

drivers/irqchip/irq-gic.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -982,7 +982,6 @@ static int gic_irq_domain_map(struct irq_domain *d, unsigned int irq,
		irq_set_percpu_devid(irq);
		irq_domain_set_info(d, irq, hw, &gic->chip, d->host_data,
		handle_percpu_devid_irq, NULL, NULL);
		irq_set_status_flags(irq, IRQ_NOAUTOEN);
		} else {
		irq_domain_set_info(d, irq, hw, &gic->chip, d->host_data,
		handle_fasteoi_irq, NULL, NULL);

Admin message