Commit cc85f7a6 authored Feb 01, 2016 by Takashi Iwai

ALSA: rawmidi: Remove kernel WARNING for NULL user-space buffer check

NULL user-space buffer can be passed even in a normal path, thus it's
not good to spew a kernel warning with stack trace at each time.
Just drop snd_BUG_ON() macro usage there.

BugLink: http://lkml.kernel.org/r/CACT4Y+YfVJ3L+q0i-4vyQVyyPD7V=OMX0PWPi29x9Bo3QaBLdw@mail.gmail.com


Reported-by: Dmitry Vyukov <dvyukov@google.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent 2d1b5c08

sound/core/rawmidi.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1178,7 +1178,7 @@ static long snd_rawmidi_kernel_write1(struct snd_rawmidi_substream *substream,
		long count1, result;
		struct snd_rawmidi_runtime *runtime = substream->runtime;

		if (snd_BUG_ON(!kernelbuf && !userbuf))
		if (!kernelbuf && !userbuf)
		return -EINVAL;
		if (snd_BUG_ON(!runtime->buffer))
		return -EINVAL;

Admin message