x86: remove suprious ifdefs from pageattr.c (cc842b82) · Commits · 戴 / test

The .rodata section really should just be read only; the config option is there to make breaking up the 2Mb page an option (so people whos machines give more performance for the 2Mb case can opt to do so). But when the page gets split anyway, this is no longer an issue, so clean up the code and remove the ifdefs Signed-off-by:

Arjan van de Ven <arjan@linux.intel.com> Signed-off-by:

Ingo Molnar <mingo@elte.hu>

arch/x86/mm/pageattr.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -167,8 +167,6 @@ static inline pgprot_t static_protections(pgprot_t prot, unsigned long address)
		if (within(address, virt_to_highmap(_text), virt_to_highmap(_etext)))
		pgprot_val(forbidden) \|= _PAGE_NX;


		#ifdef CONFIG_DEBUG_RODATA
		/* The .rodata section needs to be read-only */
		if (within(address, (unsigned long)__start_rodata,
		(unsigned long)__end_rodata))
		@@ -179,7 +177,6 @@ static inline pgprot_t static_protections(pgprot_t prot, unsigned long address)
		if (within(address, virt_to_highmap(__start_rodata),
		virt_to_highmap(__end_rodata)))
		pgprot_val(forbidden) \|= _PAGE_RW;
		#endif

		prot = __pgprot(pgprot_val(prot) & ~pgprot_val(forbidden));

Admin message