Commit cc72f6e2 authored Jan 06, 2015 by John Linville Committed by Johannes Berg Jan 07, 2015

mac80211: uninitialized return val in __ieee80211_sta_handle_tspec_ac_params



The return value should be initialized to false so that there's a
valid return value when there are no sessions that need work to be
done on them. Luckily, the side effect of using the uninitialized
value is an extra harmless driver call.

Coverity: CID 1260096
Fixes: 02219b3a ("mac80211: add WMM admission control support")
Signed-off-by: John W. Linville <linville@tuxdriver.com>
[extend commit message]
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

parent 1e359a5d

net/mac80211/mlme.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1643,7 +1643,7 @@ __ieee80211_sta_handle_tspec_ac_params(struct ieee80211_sub_if_data *sdata)
		{
		struct ieee80211_local *local = sdata->local;
		struct ieee80211_if_managed *ifmgd = &sdata->u.mgd;
		bool ret;
		bool ret = false;
		int ac;

		if (local->hw.queues < IEEE80211_NUM_ACS)

Admin message