Commit cc6a0e31 authored Apr 19, 2018 by Mika Westerberg Committed by Rafael J. Wysocki Apr 23, 2018

ACPI / scan: Initialize watchdog before PNP



At least on one Dell system the PNP motherboard resources device
includes resources used by WDAT table. Since PNP gets initialized before
WDAT it results following error and no watchdog:

  platform wdat_wdt: failed to claim resource 3: [io  0x046a-0x046c]
  ACPI: watchdog: Device creation failed: -16

Now, the PNP system driver is already accustomed with the situation that
it cannot reserve all those motherboard resources because drivers using
those might have reserved them already. In addition putting WDAT table
resources under motherboard resources device makes sense in general.

Fix this by initializing WDAT right before PNP. This allows WDAT to
reserve all its resources and still keeps PNP system driver happy.

Reported-by:  <Shubhrata.Priyadarsh@dell.com>
Reported-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Acked-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent 6d08b06e

drivers/acpi/scan.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2166,10 +2166,10 @@ int __init acpi_scan_init(void)
		acpi_cmos_rtc_init();
		acpi_container_init();
		acpi_memory_hotplug_init();
		acpi_watchdog_init();
		acpi_pnp_init();
		acpi_int340x_thermal_init();
		acpi_amba_init();
		acpi_watchdog_init();
		acpi_init_lpit();

		acpi_scan_add_handler(&generic_device_handler);

Admin message