Commit cc54d5e8 authored Apr 09, 2019 by Ville Syrjälä

drm/i915/sdvo: Fix AVI infoframe TX rate readout



The AVI infoframe readout code currently issues a
SDVO_CMD_GET_HBUF_TXRATE before SDVO_CMD_SET_HBUF_INDEX, which is
not the correct order for these two operations. So far this wasn't
a problem since we left the index pointing at the AVI infoframe
buffer at the end of the modeset. However once we start to write
to other buffers (namely ELD) that is no longer going to be true.
Fix up the order so that we always read out the TX rate for the
correct buffer.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190409144054.24561-2-ville.syrjala@linux.intel.com


Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

parent 38f30041

drivers/gpu/drm/i915/intel_sdvo.c

+5 −5

Original line number	Diff line number	Diff line
		@@ -1005,6 +1005,11 @@ static ssize_t intel_sdvo_read_infoframe(struct intel_sdvo *intel_sdvo,
		if (av_split < if_index)
		return 0;

		if (!intel_sdvo_set_value(intel_sdvo,
		SDVO_CMD_SET_HBUF_INDEX,
		set_buf_index, 2))
		return -ENXIO;

		if (!intel_sdvo_get_value(intel_sdvo,
		SDVO_CMD_GET_HBUF_TXRATE,
		&tx_rate, 1))
		@@ -1013,11 +1018,6 @@ static ssize_t intel_sdvo_read_infoframe(struct intel_sdvo *intel_sdvo,
		if (tx_rate == SDVO_HBUF_TX_DISABLED)
		return 0;

		if (!intel_sdvo_set_value(intel_sdvo,
		SDVO_CMD_SET_HBUF_INDEX,
		set_buf_index, 2))
		return -ENXIO;

		if (!intel_sdvo_get_value(intel_sdvo, SDVO_CMD_GET_HBUF_INFO,
		&hbuf_size, 1))
		return -ENXIO;

Admin message