Commit cc4ccaaf authored Mar 23, 2018 by Tudor-Dan Ambarus Committed by Herbert Xu Mar 31, 2018

crypto: caam/qi - don't leak pointers to authenc keys



In caam/qi's aead_setkey we save pointers to the authenc keys in
a local variable of type struct crypto_authenc_keys and we don't
zeroize it after use. Fix this and don't leak pointers to the
authenc keys.

Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Reviewed-by: Horia Geantă <horia.geanta@nxp.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent 61dab972

drivers/crypto/caam/caamalg_qi.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -278,9 +278,11 @@ skip_split_key:
		}
		}

		memzero_explicit(&keys, sizeof(keys));
		return ret;
		badkey:
		crypto_aead_set_flags(aead, CRYPTO_TFM_RES_BAD_KEY_LEN);
		memzero_explicit(&keys, sizeof(keys));
		return -EINVAL;
		}

Admin message