Unverified Commit cc20c4df authored Nov 06, 2017 by Arnd Bergmann Committed by Mark Brown Nov 07, 2017

ASoC: intel: initialize return value properly



When CONFIG_SND_SOC_HDAC_HDMI is disabled, we can run into an
uninitialized variable:

sound/soc/intel/skylake/skl.c: In function 'skl_resume':
sound/soc/intel/skylake/skl.c:326:6: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized]

I have run into this on today's linux-next kernel, but it appears
that this is an older problem that was just hard to trigger
with randconfig builds as CONFIG_SND_SOC_HDAC_HDMI would in
effect be impossible to disable when having SND_SOC_INTEL_SKYLAKE
enabled.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-By: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent adebc532

sound/soc/intel/skylake/skl.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -355,6 +355,7 @@ static int skl_resume(struct device *dev)

		if (ebus->cmd_dma_state)
		snd_hdac_bus_init_cmd_io(&ebus->bus);
		ret = 0;
		} else {
		ret = _skl_resume(ebus);

Admin message