Commit cc1f0274 authored Sep 24, 2013 by Frederic Weisbecker

irq: Optimize softirq stack selection in irq exit



If irq_exit() is called on the arch's specified irq stack,
it should be safe to run softirqs inline under that same
irq stack as it is near empty by the time we call irq_exit().

For example if we use the same stack for both hard and soft irqs here,
the worst case scenario is:
hardirq -> softirq -> hardirq. But then the softirq supersedes the
first hardirq as the stack user since irq_exit() is called in
a mostly empty stack. So the stack merge in this case looks acceptable.

Stack overrun still have a chance to happen if hardirqs have more
opportunities to nest, but then it's another problem to solve.

So lets adapt the irq exit's softirq stack on top of a new Kconfig symbol
that can be defined when irq_exit() runs on the irq stack. That way
we can spare some stack switch on irq processing and all the cache
issues that come along.

Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@au1.ibm.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Paul Mackerras <paulus@au1.ibm.com>
Cc: James Hogan <james.hogan@imgtec.com>
Cc: James E.J. Bottomley <jejb@parisc-linux.org>
Cc: Helge Deller <deller@gmx.de>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: Andrew Morton <akpm@linux-foundation.org>

parent 0bed698a

arch/Kconfig

+10 −0

Original line number	Diff line number	Diff line
		@@ -390,6 +390,16 @@ config HAVE_UNDERSCORE_SYMBOL_PREFIX
		Some architectures generate an _ in front of C symbols; things like
		module loading and assembly files need to know about this.

		config HAVE_IRQ_EXIT_ON_IRQ_STACK
		bool
		help
		Architecture doesn't only execute the irq handler on the irq stack
		but also irq_exit(). This way we can process softirqs on this irq
		stack instead of switching to a new one when we call __do_softirq()
		in the end of an hardirq.
		This spares a stack switch and improves cache usage on softirq
		processing.

		#
		# ABI hall of shame
		#

kernel/softirq.c

+10 −4

Original line number	Diff line number	Diff line
		@@ -332,15 +332,21 @@ void irq_enter(void)
		static inline void invoke_softirq(void)
		{
		if (!force_irqthreads) {
		#ifdef CONFIG_HAVE_IRQ_EXIT_ON_IRQ_STACK
		/*
		* We can safely execute softirq on the current stack if
		* it is the irq stack, because it should be near empty
		* at this stage. But we have no way to know if the arch
		* calls irq_exit() on the irq stack. So call softirq
		* in its own stack to prevent from any overrun on top
		* of a potentially deep task stack.
		* at this stage.
		*/
		__do_softirq();
		#else
		/*
		* Otherwise, irq_exit() is called on the task stack that can
		* be potentially deep already. So call softirq in its own stack
		* to prevent from any overrun.
		*/
		do_softirq_own_stack();
		#endif
		} else {
		wakeup_softirqd();
		}

Admin message