Commit cc0a5a86 authored Feb 15, 2017 by Gustavo Padovan Committed by Mauro Carvalho Chehab Mar 22, 2017

[media] vivid: improve subscribe event handling



We already check for the V4L2_EVENT_CTRL inside
v4l2_ctrl_subscribe_event() so just move this fuction to the default:
branch of the switch and let it does the job for us.

Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

parent aac5987a

drivers/media/platform/vivid/vivid-vid-out.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -1172,14 +1172,12 @@ int vidioc_subscribe_event(struct v4l2_fh *fh,
		const struct v4l2_event_subscription *sub)
		{
		switch (sub->type) {
		case V4L2_EVENT_CTRL:
		return v4l2_ctrl_subscribe_event(fh, sub);
		case V4L2_EVENT_SOURCE_CHANGE:
		if (fh->vdev->vfl_dir == VFL_DIR_RX)
		return v4l2_src_change_event_subscribe(fh, sub);
		break;
		default:
		break;
		return v4l2_ctrl_subscribe_event(fh, sub);
		}
		return -EINVAL;
		}

Admin message