Commit cc05ea0c authored May 04, 2010 by Jassi Brar Committed by Dan Williams May 17, 2010

DMA ENGINE: Do not reset 'private' of channel



The member 'private' of 'struct dma_chan' is meant for passing
data between client and the controller driver.

The DMA client driver may point it to platform specific stuff after
acquiring the channel. So, it is the responsiblity of the same code
to reset it, if it must.

The DMA engine doesn't set it and hence, shouldn't reset it either.

This reseting of private by DMA Engine comes in the way of implementing
default channel settings during DMAC probe. That capability is useful
for not having the clients to always provide platform specific data,
like Rx/Tx FIFO addresses, which usually doesn't change across channel
requests.

Signed-off-by: Jassi Brar <jassi.brar@samsung.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>

parent 8d318a50

drivers/dma/dmaengine.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -514,7 +514,6 @@ struct dma_chan __dma_request_channel(dma_cap_mask_t mask, dma_filter_fn fn, v
		break;
		if (--device->privatecnt == 0)
		dma_cap_clear(DMA_PRIVATE, device->cap_mask);
		chan->private = NULL;
		chan = NULL;
		}
		}
		@@ -536,7 +535,6 @@ void dma_release_channel(struct dma_chan *chan)
		/* drop PRIVATE cap enabled by __dma_request_channel() */
		if (--chan->device->privatecnt == 0)
		dma_cap_clear(DMA_PRIVATE, chan->device->cap_mask);
		chan->private = NULL;
		mutex_unlock(&dma_list_mutex);
		}
		EXPORT_SYMBOL_GPL(dma_release_channel);

Admin message