kgdb/treewide: constify struct kgdb_arch arch_kgdb_ops (cc028297) · Commits · 戴 / test

checkpatch.pl reports the following: WARNING: struct kgdb_arch should normally be const #28: FILE: arch/mips/kernel/kgdb.c:397: +struct kgdb_arch arch_kgdb_ops = { This report makes sense, as all other ops struct, this one should also be const. This patch does the change. Cc: Vineet Gupta <vgupta@synopsys.com> Cc: Russell King <linux@armlinux.org.uk> Cc: Catalin Marinas <catalin.marinas@arm.com> Cc: Will Deacon <will.deacon@arm.com> Cc: Yoshinori Sato <ysato@users.sourceforge.jp> Cc: Richard Kuo <rkuo@codeaurora.org> Cc: Michal Simek <monstr@monstr.eu> Cc: Ralf Baechle <ralf@linux-mips.org> Cc: Paul Burton <paul.burton@mips.com> Cc: James Hogan <jhogan@kernel.org> Cc: Ley Foon Tan <lftan@altera.com> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: Paul Mackerras <paulus@samba.org> Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: Rich Felker <dalias@libc.org> Cc: "David S. Miller" <davem@davemloft.net> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Ingo Molnar <mingo@redhat.com> Cc: Borislav Petkov <bp@alien8.de> Cc: x86@kernel.org Acked-by:

Daniel Thompson <daniel.thompson@linaro.org> Acked-by:

Paul Burton <paul.burton@mips.com> Signed-off-by:

Christophe Leroy <christophe.leroy@c-s.fr> Acked-by:

Borislav Petkov <bp@suse.de> Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc) Signed-off-by:

Daniel Thompson <daniel.thompson@linaro.org>

arch/arc/kernel/kgdb.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -198,7 +198,7 @@ void kgdb_call_nmi_hook(void *ignored)
		kgdb_nmicallback(raw_smp_processor_id(), NULL);
		}

		struct kgdb_arch arch_kgdb_ops = {
		const struct kgdb_arch arch_kgdb_ops = {
		/* breakpoint instruction: TRAP_S 0x3 */
		#ifdef CONFIG_CPU_BIG_ENDIAN
		.gdb_bpt_instr = {0x78, 0x7e},

arch/arm/kernel/kgdb.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -262,7 +262,7 @@ int kgdb_arch_remove_breakpoint(struct kgdb_bkpt *bpt)
		* and we handle the normal undef case within the do_undefinstr
		* handler.
		*/
		struct kgdb_arch arch_kgdb_ops = {
		const struct kgdb_arch arch_kgdb_ops = {
		#ifndef __ARMEB__
		.gdb_bpt_instr = {0xfe, 0xde, 0xff, 0xe7}
		#else /* ! __ARMEB__ */

arch/arm64/kernel/kgdb.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -345,7 +345,7 @@ void kgdb_arch_exit(void)
		unregister_die_notifier(&kgdb_notifier);
		}

		struct kgdb_arch arch_kgdb_ops;
		const struct kgdb_arch arch_kgdb_ops;

		int kgdb_arch_set_breakpoint(struct kgdb_bkpt *bpt)
		{

arch/h8300/kernel/kgdb.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -129,7 +129,7 @@ void kgdb_arch_exit(void)
		/* Nothing to do */
		}

		struct kgdb_arch arch_kgdb_ops = {
		const struct kgdb_arch arch_kgdb_ops = {
		/* Breakpoint instruction: trapa #2 */
		.gdb_bpt_instr = { 0x57, 0x20 },
		};

arch/hexagon/kernel/kgdb.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -83,7 +83,7 @@ struct dbg_reg_def_t dbg_reg_def[DBG_MAX_REG_NUM] = {
		{ "syscall_nr", GDB_SIZEOF_REG, offsetof(struct pt_regs, syscall_nr)},
		};

		struct kgdb_arch arch_kgdb_ops = {
		const struct kgdb_arch arch_kgdb_ops = {
		/* trap0(#0xDB) 0x0cdb0054 */
		.gdb_bpt_instr = {0x54, 0x00, 0xdb, 0x0c},
		};

Admin message