mfd: aat2870: No need to check return value of debugfs_create functions (cbfe612d) · Commits · 戴 / test

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by:

Lee Jones <lee.jones@linaro.org>

drivers/mfd/aat2870-core.c

+2 −11

Original line number	Diff line number	Diff line
		@@ -321,18 +321,9 @@ static const struct file_operations aat2870_reg_fops = {
		static void aat2870_init_debugfs(struct aat2870_data *aat2870)
		{
		aat2870->dentry_root = debugfs_create_dir("aat2870", NULL);
		if (!aat2870->dentry_root) {
		dev_warn(aat2870->dev,
		"Failed to create debugfs root directory\n");
		return;
		}

		aat2870->dentry_reg = debugfs_create_file("regs", 0644,
		aat2870->dentry_root,
		aat2870, &aat2870_reg_fops);
		if (!aat2870->dentry_reg)
		dev_warn(aat2870->dev,
		"Failed to create debugfs register file\n");
		debugfs_create_file("regs", 0644, aat2870->dentry_root, aat2870,
		&aat2870_reg_fops);
		}

		#else

include/linux/mfd/aat2870.h

+0 −1

Original line number	Diff line number	Diff line
		@@ -136,7 +136,6 @@ struct aat2870_data {

		/* for debugfs */
		struct dentry *dentry_root;
		struct dentry *dentry_reg;
		};

		struct aat2870_subdev_info {

Admin message