Commit cbe62fac authored Oct 30, 2016 by Paul Gortmaker Committed by Martin Schwidefsky Oct 31, 2016

s390: char: make zcore explicitly non-modular



The Kconfig currently controlling compilation of this code is:

arch/s390/Kconfig:config CRASH_DUMP
arch/s390/Kconfig:      bool "kernel crash dumps"

...meaning that it currently is not being built as a module by anyone.

Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.

Since module_init wasn't even being used by this file, the init
ordering remains unchanged with this commit.

We also delete the MODULE_LICENSE tag etc. since all that information
was (or is now) contained at the top of the file in the comments.

We don't replace module.h with init.h since the file already has that.

Cc: linux-s390@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>

parent a00f761f

drivers/s390/char/zcore.c

+1 −19

Original line number	Diff line number	Diff line
		@@ -7,6 +7,7 @@
		*
		* Copyright IBM Corp. 2003, 2008
		* Author(s): Michael Holzheu
		* License: GPL
		*/

		#define KMSG_COMPONENT "zdump"
		@@ -16,7 +17,6 @@
		#include <linux/slab.h>
		#include <linux/miscdevice.h>
		#include <linux/debugfs.h>
		#include <linux/module.h>
		#include <linux/memblock.h>

		#include <asm/asm-offsets.h>
		@@ -364,22 +364,4 @@ fail:
		diag308(DIAG308_REL_HSA, NULL);
		return rc;
		}

		static void __exit zcore_exit(void)
		{
		debug_unregister(zcore_dbf);
		sclp_sdias_exit();
		free_page((unsigned long) ipl_block);
		debugfs_remove(zcore_hsa_file);
		debugfs_remove(zcore_reipl_file);
		debugfs_remove(zcore_memmap_file);
		debugfs_remove(zcore_dir);
		diag308(DIAG308_REL_HSA, NULL);
		}

		MODULE_AUTHOR("Copyright IBM Corp. 2003,2008");
		MODULE_DESCRIPTION("zcore module for zfcpdump support");
		MODULE_LICENSE("GPL");

		subsys_initcall(zcore_init);
		module_exit(zcore_exit);

Admin message