Commit cbd50b3c authored Jul 05, 2019 by Hou Zhiqiang Committed by Lorenzo Pieralisi Jul 08, 2019

PCI: mobiveil: Fix devfn check in mobiveil_pcie_valid_device()



Current check for devfn number in mobiveil_pci_valid_device() is
wrong in that it flags as invalid functions present in PCI device 0
in the root bus while it is perfectly valid to access all functions
in PCI device 0 in the root bus.

Update the check in mobiveil_pci_valid_device() to fix the issue.

Fixes: 9af6bcb1 ("PCI: mobiveil: Add Mobiveil PCIe Host Bridge IP driver")
Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Reviewed-by: Minghuan Lian <Minghuan.Lian@nxp.com>

parent 6f3ab451

drivers/pci/controller/pcie-mobiveil.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -283,7 +283,7 @@ static bool mobiveil_pcie_valid_device(struct pci_bus *bus, unsigned int devfn)
		* Do not read more than one device on the bus directly
		* attached to RC
		*/
		if ((bus->primary == pcie->root_bus_nr) && (devfn > 0))
		if ((bus->primary == pcie->root_bus_nr) && (PCI_SLOT(devfn) > 0))
		return false;

		return true;

Admin message