Commit cbd27ee7 authored Jun 10, 2012 by Avi Kivity

KVM: x86 emulator: initialize memop



memop is not initialized; this can lead to a two-byte operation
following a 4-byte operation to see garbage values.  Usually
truncation fixes things fot us later on, but at least in one case
(call abs) it doesn't.

Fix by moving memop to the auto-initialized field area.

Signed-off-by: Avi Kivity <avi@redhat.com>

parent f47cfa31

arch/x86/include/asm/kvm_emulate.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -280,9 +280,9 @@ struct x86_emulate_ctxt {
		u8 modrm_seg;
		bool rip_relative;
		unsigned long _eip;
		struct operand memop;
		/* Fields above regs are cleared together. */
		unsigned long regs[NR_VCPU_REGS];
		struct operand memop;
		struct operand *memopp;
		struct fetch_cache fetch;
		struct read_cache io_read;

Admin message