Commit cbb33004 authored Jun 15, 2011 by Alan Stern Committed by Greg Kroah-Hartman Jun 15, 2011

USB: don't let the hub driver prevent system sleep



This patch (as1465) continues implementation of the policy that errors
during suspend or hibernation should not prevent the system from going
to sleep.

In this case, failure to turn on the Suspend feature for a hub port
shouldn't be reported as an error.  There are situations where this
does actually occur (such as when the device plugged into that port
was disconnected in the recent past), and it turns out to be harmless.
There's no reason for it to prevent a system sleep.

Also, don't allow the hub driver to fail a system suspend if the
downstream ports aren't all suspended.  This is also harmless (and
should never happen, given the change mentioned above); printing a
warning message in the kernel log is all we really need to do.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
CC: <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent 578333ab

drivers/usb/core/hub.c

+8 −5

Original line number	Diff line number	Diff line
		@@ -2362,6 +2362,10 @@ int usb_port_suspend(struct usb_device *udev, pm_message_t msg)
		USB_DEVICE_REMOTE_WAKEUP, 0,
		NULL, 0,
		USB_CTRL_SET_TIMEOUT);

		/* System sleep transitions should never fail */
		if (!(msg.event & PM_EVENT_AUTO))
		status = 0;
		} else {
		/* device has up to 10 msec to fully suspend */
		dev_dbg(&udev->dev, "usb %ssuspend\n",
		@@ -2611,15 +2615,14 @@ static int hub_suspend(struct usb_interface *intf, pm_message_t msg)
		struct usb_device *hdev = hub->hdev;
		unsigned port1;

		/* fail if children aren't already suspended */
		/* Warn if children aren't already suspended */
		for (port1 = 1; port1 <= hdev->maxchild; port1++) {
		struct usb_device *udev;

		udev = hdev->children [port1-1];
		if (udev && udev->can_submit) {
		if (!(msg.event & PM_EVENT_AUTO))
		dev_dbg(&intf->dev, "port %d nyet suspended\n",
		port1);
		dev_warn(&intf->dev, "port %d nyet suspended\n", port1);
		if (msg.event & PM_EVENT_AUTO)
		return -EBUSY;
		}
		}

Admin message