Commit cba76717 authored Dec 06, 2008 by Kay Sievers Committed by Linus Torvalds Dec 10, 2008

pktcdvd: remove broken dev_t export of class devices



The pktcdvd created class devices only export some sysfs files,
but have no char dev_t registered in the driver.

At class device creation time they copy the dev_t value of the
block device to the char device, wich will register a new char
device in the driver core and userspace, with a conflicting dev_t
value.

In many cases the class devices dev_t just points to a random
USB device. This fixes the sysfs "duplicate entry" errors.

Signed-off-by: Kay Sievers <kay.sievers@vrfy.org>
Acked-by: Peter Osterlund <petero2@telia.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent cdcb30b5

drivers/block/pktcdvd.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -302,7 +302,7 @@ static struct kobj_type kobj_pkt_type_wqueue = {
		static void pkt_sysfs_dev_new(struct pktcdvd_device *pd)
		{
		if (class_pktcdvd) {
		pd->dev = device_create(class_pktcdvd, NULL, pd->pkt_dev, NULL,
		pd->dev = device_create(class_pktcdvd, NULL, MKDEV(0, 0), NULL,
		"%s", pd->name);
		if (IS_ERR(pd->dev))
		pd->dev = NULL;

Admin message