Commit cb958186 authored Aug 19, 2006 by Eric Sesterhenn Committed by Jeff Garzik Aug 24, 2006

[PATCH] Signedness issue in drivers/net/3c515.c



while playing with gcc 4.1 -Wextra warnings, I came across this one:

drivers/net/3c515.c:1027: warning: comparison of unsigned expression >= 0 is always true

Since i is unsigned the >= 0 check in the for loop is always true,
so we might spin there forever unless the if condition triggers.
Since i is only used in this loop, this patch changes it to
an integer.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Jeff Garzik <jeff@garzik.org>

parent a76b044a

drivers/net/3c515.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1003,7 +1003,8 @@ static int corkscrew_start_xmit(struct sk_buff *skb,
		/* Calculate the next Tx descriptor entry. */
		int entry = vp->cur_tx % TX_RING_SIZE;
		struct boom_tx_desc *prev_entry;
		unsigned long flags, i;
		unsigned long flags;
		int i;

		if (vp->tx_full) /* No room to transmit with */
		return 1;

Admin message