staging: comedi: usbduxfast: tidy up usbduxfastsub_unlink_InURBs() (cb8c0034) · Commits · 戴 / test

Rename this function so it has namespace associated with the driver. Remove the local variables 'j' and 'ret'. They are not used and the function always returns '0'. Signed-off-by:

H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/staging/comedi/drivers/usbduxfast.c

+3 −6

Original line number	Diff line number	Diff line
		@@ -189,19 +189,16 @@ static int usbduxfast_send_cmd(struct comedi_device *dev, int cmd_type)
		* Stops the data acquision.
		* It should be safe to call this function from any context.
		*/
		static int usbduxfastsub_unlink_InURBs(struct comedi_device *dev)
		static int usbduxfast_unlink_urbs(struct comedi_device *dev)
		{
		struct usbduxfast_private *devpriv = dev->private;
		int j = 0;
		int err = 0;

		if (devpriv && devpriv->urb) {
		devpriv->ai_cmd_running = 0;
		/* waits until a running transfer is over */
		usb_kill_urb(devpriv->urb);
		j = 0;
		}
		return err;
		return 0;
		}

		/*
		@@ -224,7 +221,7 @@ static int usbduxfast_ai_stop(struct comedi_device *dev,

		if (do_unlink)
		/* stop aquistion */
		ret = usbduxfastsub_unlink_InURBs(dev);
		ret = usbduxfast_unlink_urbs(dev);

		return ret;
		}

Admin message