Commit cb814642 authored by Lijun Ou's avatar Lijun Ou Committed by Doug Ledford
Browse files

IB/hns: Validate mtu when modified qp 



The mtu should be validated when modify qp,so we check it.

Signed-off-by: default avatarLijun Ou <oulijun@huawei.com>
Signed-off-by: default avatarPeter Chen <luck.chen@huawei.com>
Reviewed-by: default avatarWei Hu (Xavier) <xavier.huwei@huawei.com>
Signed-off-by: default avatarSalil Mehta <salil.mehta@huawei.com>
Signed-off-by: default avatarDoug Ledford <dledford@redhat.com>
parent 7c7a4ea1

drivers/infiniband/hw/hns/hns_roce_qp.c

+15 −0
Original line number Diff line number Diff line
@@ -32,6 +32,7 @@ 
 */



#include <linux/platform_device.h>

#include <rdma/ib_addr.h>

#include <rdma/ib_umem.h>

#include "hns_roce_common.h"

#include "hns_roce_device.h"
@@ -657,6 +658,7 @@ int hns_roce_modify_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr, 
	struct device *dev = &hr_dev->pdev->dev;

	int ret = -EINVAL;

	int p;

	enum ib_mtu active_mtu;



	mutex_lock(&hr_qp->mutex);
@@ -687,6 +689,19 @@ int hns_roce_modify_qp(struct ib_qp *ibqp, struct ib_qp_attr *attr, 
		}

	}



	if (attr_mask & IB_QP_PATH_MTU) {

		p = attr_mask & IB_QP_PORT ? (attr->port_num - 1) : hr_qp->port;

		active_mtu = iboe_get_mtu(hr_dev->iboe.netdevs[p]->mtu);



		if (attr->path_mtu > IB_MTU_2048 ||

		    attr->path_mtu < IB_MTU_256 ||

		    attr->path_mtu > active_mtu) {

			dev_err(dev, "attr path_mtu(%d)invalid while modify qp",

				attr->path_mtu);

			goto out;

		}

	}



	if (attr_mask & IB_QP_MAX_QP_RD_ATOMIC &&

	    attr->max_rd_atomic > hr_dev->caps.max_qp_init_rdma) {

		dev_err(dev, "attr max_rd_atomic invalid.attr->max_rd_atomic=%d\n",

CRA Git | Maintained and supported by SUSTech CRA and CCSE