Commit cb7dc317 authored Aug 06, 2020 by Evgeny Novikov Committed by Miquel Raynal Sep 30, 2020

mtd: rawnand: vf610: disable clk on error handling path in probe

vf610_nfc_probe() does not invoke clk_disable_unprepare() on one error
handling path. The patch fixes that.

Found by Linux Driver Verification project (linuxtesting.org).

Fixes: 6f0ce4df ("mtd: rawnand: vf610: Avoid a potential NULL pointer dereference")
Signed-off-by: Evgeny Novikov <novikov@ispras.ru>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20200806072634.23528-1-novikov@ispras.ru

parent d43511d0

drivers/mtd/nand/raw/vf610_nfc.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -852,8 +852,10 @@ static int vf610_nfc_probe(struct platform_device *pdev)
		}

		of_id = of_match_device(vf610_nfc_dt_ids, &pdev->dev);
		if (!of_id)
		return -ENODEV;
		if (!of_id) {
		err = -ENODEV;
		goto err_disable_clk;
		}

		nfc->variant = (enum vf610_nfc_variant)of_id->data;