Commit cb77fcd8 authored Jun 15, 2012 by Josef Bacik Committed by Chris Mason Jun 21, 2012

Btrfs: delay iput with async extents

There is some concern that these iput()'s could be the final iputs and could
induce lockups on people waiting on writeback. This would happen in the
rare case that we don't create ordered extents because of an error, but it
is theoretically possible and we already have a mechanism to deal with this
so just make them delayed iputs to negate any worry.

Signed-off-by: Josef Bacik <josef@redhat.com>
Signed-off-by: Chris Mason <chris.mason@fusionio.com>

parent e18fca73

fs/btrfs/inode.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -987,7 +987,7 @@ static noinline void async_cow_start(struct btrfs_work *work)
		async_cow->start, async_cow->end, async_cow,
		&num_added);
		if (num_added == 0) {
		iput(async_cow->inode);
		btrfs_add_delayed_iput(async_cow->inode);
		async_cow->inode = NULL;
		}
		}
		@@ -1023,7 +1023,7 @@ static noinline void async_cow_free(struct btrfs_work *work)
		struct async_cow *async_cow;
		async_cow = container_of(work, struct async_cow, work);
		if (async_cow->inode)
		iput(async_cow->inode);
		btrfs_add_delayed_iput(async_cow->inode);
		kfree(async_cow);
		}

Admin message