Commit cb734cf7 authored Mar 12, 2016 by Bhaktipriya Shridhar Committed by Greg Kroah-Hartman Mar 11, 2016

staging: lustre: lnet: config: Use list_for_each_entry_safe



Doubly linked lists which are  iterated  using list_empty
and list_entry macros have been replaced with list_for_each_entry_safe
macro.
This makes the iteration simpler and more readable.

This patch replaces the while loop containing list_empty and list_entry
with list_for_each_entry_safe.

This was done with Coccinelle.

@@
expression E1;
identifier I1, I2;
type T;
iterator name list_for_each_entry_safe;
@@

T *I1;
+ T *tmp;
...
- while (list_empty(&E1) == 0)
+ list_for_each_entry_safe (I1, tmp, &E1, I2)
{
...when != T *I1;
- I1 = list_entry(E1.next, T, I2);
...
}

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 37cce1bc

drivers/staging/lustre/lnet/lnet/config.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -1020,6 +1020,7 @@ lnet_match_networks(char *networksp, char ip2nets, __u32 *ipaddrs, int nip)
		struct list_head *t;
		struct list_head *t2;
		struct lnet_text_buf *tb;
		struct lnet_text_buf *temp;
		struct lnet_text_buf *tb2;
		__u32 net1;
		__u32 net2;
		@@ -1042,9 +1043,7 @@ lnet_match_networks(char *networksp, char ip2nets, __u32 *ipaddrs, int nip)
		len = 0;
		rc = 0;

		while (!list_empty(&raw_entries)) {
		tb = list_entry(raw_entries.next, struct lnet_text_buf,
		ltb_list);
		list_for_each_entry_safe(tb, temp, &raw_entries, ltb_list) {
		strncpy(source, tb->ltb_text, sizeof(source));
		source[sizeof(source) - 1] = '\0';

Admin message