Commit cb710eca authored Oct 26, 2010 by Joe Perches Committed by Linus Torvalds Oct 26, 2010

scripts/checkpatch.pl: add warnings for static char that could be static const char



Add warnings for possible missing const uses of
	static char foo[] = "bar"
    that could be
	static const char foo[] = "bar"
and
	static const char *foo[] = {"bar", "baz"}
    that could be
	static const char * const foo[] = {"bar", "baz"}

Signed-off-by: Joe Perches <joe@perches.com>
Cc: Mike Frysinger <vapier.adi@gmail.com>
Cc: Andy Whitcroft <apw@canonical.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 267ad8f4

scripts/checkpatch.pl

+12 −0

Original line number	Diff line number	Diff line
		@@ -1869,6 +1869,18 @@ sub process {
		$herecurr);
		}

		# check for static const char * arrays.
		if ($line =~ /\bstatic\s+const\s+char\s\\s(\w+)\s\[\s\]\s=\s*/) {
		WARN("static const char * array should probably be static const char * const\n" .
		$herecurr);
		}

		# check for static char foo[] = "bar" declarations.
		if ($line =~ /\bstatic\s+char\s+(\w+)\s\[\s\]\s=\s"/) {
		WARN("static char array declaration should probably be static const char\n" .
		$herecurr);
		}

		# check for new typedefs, only function parameters and sparse annotations
		# make sense.
		if ($line =~ /\btypedef\s/ &&

Admin message