Commit cb60e960 authored Aug 31, 2020 by Viresh Kumar

opp: Prevent memory leak in dev_pm_opp_attach_genpd()



If dev_pm_opp_attach_genpd() is called multiple times (once for each CPU
sharing the table), then it would result in unwanted behavior like
memory leak, attaching the domain multiple times, etc.

Handle that by checking and returning earlier if the domains are already
attached. Now that dev_pm_opp_detach_genpd() can get called multiple
times as well, we need to protect that too.

Note that the virtual device pointers aren't returned in this case, as
they may become unavailable to some callers during the middle of the
operation.

Reported-by: Stephan Gerhold <stephan@gerhold.net>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

parent 7162fc2e

drivers/opp/core.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -1960,6 +1960,9 @@ static void _opp_detach_genpd(struct opp_table *opp_table)
		{
		int index;

		if (!opp_table->genpd_virt_devs)
		return;

		for (index = 0; index < opp_table->required_opp_count; index++) {
		if (!opp_table->genpd_virt_devs[index])
		continue;
		@@ -2006,6 +2009,9 @@ struct opp_table dev_pm_opp_attach_genpd(struct device dev,
		if (IS_ERR(opp_table))
		return opp_table;

		if (opp_table->genpd_virt_devs)
		return opp_table;

		/*
		* If the genpd's OPP table isn't already initialized, parsing of the
		* required-opps fail for dev. We should retry this after genpd's OPP

Admin message