Commit cb5ef42a authored Jun 27, 2008 by Peter Zijlstra Committed by Ingo Molnar Jun 27, 2008

sched: optimize effective_load()



s_i = S * rw_i / \Sum_j rw_j

 -> \Sum_j rw_j = S * rw_i / s_i

 -> s'_i = S * (rw_i + w) / (\Sum_j rw_j + w)

delta s = s' - s = S * (rw + w) / ((S * rw / s) + w)
        = s * (S * (rw + w) / (S * rw + s * w) - 1)

 a = S*(rw+w), b = S*rw + s*w

delta s = s * (a-b) / b

IOW, trade one divide for two multiplies

Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
Cc: Mike Galbraith <efault@gmx.de>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent 051c6764

kernel/sched_fair.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -1082,16 +1082,16 @@ static unsigned long effective_load(struct task_group *tg, long wl, int cpu)
		for_each_sched_entity(se) {
		#define D(n) (likely(n) ? (n) : 1)

		long S, Srw, rw, s, sn;
		long S, rw, s, a, b;

		S = se->my_q->tg->shares;
		s = se->my_q->shares;
		rw = se->my_q->load.weight;

		Srw = S * rw / D(s);
		sn = S * (rw + wl) / D(Srw + wg);
		a = S*(rw + wl);
		b = Srw + swg;

		wl = sn - s;
		wl = s*(a-b)/D(b);
		wg = 0;
		#undef D
		}

Admin message