Commit cb5172d9 authored Dec 02, 2019 by Amol Grover Committed by Paul Moore Dec 09, 2019

audit: Add __rcu annotation to RCU pointer



Add __rcu annotation to RCU-protected global pointer auditd_conn.

auditd_conn is an RCU-protected global pointer,i.e., accessed
via RCU methods rcu_dereference() and rcu_assign_pointer(),
hence it must be annotated with __rcu for sparse to report
warnings/errors correctly.

Fix multiple instances of the sparse error:
error: incompatible types in comparison expression
(different address spaces)

Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org>
Signed-off-by: Amol Grover <frextrite@gmail.com>
[PM: tweak subject line]
Signed-off-by: Paul Moore <paul@paul-moore.com>

parent e42617b8

kernel/audit.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -102,12 +102,13 @@ struct audit_net {
		* This struct is RCU protected; you must either hold the RCU lock for reading
		* or the associated spinlock for writing.
		*/
		static struct auditd_connection {
		struct auditd_connection {
		struct pid *pid;
		u32 portid;
		struct net *net;
		struct rcu_head rcu;
		} *auditd_conn = NULL;
		};
		static struct auditd_connection __rcu *auditd_conn;
		static DEFINE_SPINLOCK(auditd_conn_lock);

		/* If audit_rate_limit is non-zero, limit the rate of sending audit records

Admin message