Commit cb49dbb1 authored Apr 17, 2008 by Eric Sandeen Committed by Lachlan McIlroy Apr 18, 2008

[XFS] Always use di_forkoff when checking for attr space.



In the case where we mount a filesystem which was previously using the
attr2 format as attr1, returning the default mp->m_attroffset instead of
the per-inode di_forkoff for inline attribute fit calculations, may result
in corruption, if for example, the data fork is already taking more space
than the default fork offset and we try to add an extended attribute. Fix
tested by xfstests/186.

SGI-PV: 979606
SGI-Modid: xfs-linux-melb:xfs-kern:30861a

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Signed-off-by: Tim Shimmin <tes@sgi.com>
Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>

parent f6485057

fs/xfs/xfs_attr_leaf.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -166,7 +166,7 @@ xfs_attr_shortform_bytesfit(xfs_inode_t *dp, int bytes)

	if (!(mp->m_flags & XFS_MOUNT_ATTR2)) {		if (!(mp->m_flags & XFS_MOUNT_ATTR2)) {
	if (bytes <= XFS_IFORK_ASIZE(dp))		if (bytes <= XFS_IFORK_ASIZE(dp))
	return mp->m_attroffset >> 3;		return dp->i_d.di_forkoff;
	return 0;		return 0;
	}		}

Admin message