Commit cb45e529 authored Jun 21, 2017 by James Smart Committed by Martin K. Petersen Jun 26, 2017

scsi: lpfc: fix refcount error on node list



A change in remote port removal introduced a spurious put which can
cause a premature structure teardown. The affects were most notable when
the driver attempted to unload as a null pointer would be hit.

Fix by removing the unnecessary put.

Signed-off-by: James Smart <james.smart@broadcom.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 00cefeb9

drivers/scsi/lpfc/lpfc_init.c

+0 −7

Original line number	Diff line number	Diff line
		@@ -2805,13 +2805,6 @@ lpfc_cleanup(struct lpfc_vport *vport)
		lpfc_disc_state_machine(vport, ndlp, NULL,
		NLP_EVT_DEVICE_RECOVERY);

		if (ndlp->nlp_fc4_type & NLP_FC4_NVME) {
		/* Remove the NVME transport reference now and
		* continue to remove the node.
		*/
		lpfc_nlp_put(ndlp);
		}

		lpfc_disc_state_machine(vport, ndlp, NULL,
		NLP_EVT_DEVICE_RM);
		}

Admin message