Commit cb3f35bb authored Feb 04, 2009 by Christoph Hellwig Committed by Christoph Hellwig Feb 04, 2009

xfs: tiny cleanup for xfs_link



The source and target inodes are guaranteed to never be the same by the VFS,
so no need to check for that (and we would get into bad trouble later anyway
if that were the case).  Also clean up the error handling to use two gotos
instead of nested conditions.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Felix Blyakher <felixb@sgi.com>

parent b93b6e43

fs/xfs/xfs_vnodeops.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -2004,7 +2004,9 @@ xfs_link(
		/* Return through std_return after this point. */

		error = XFS_QM_DQATTACH(mp, sip, 0);
		if (!error && sip != tdp)
		if (error)
		goto std_return;

		error = XFS_QM_DQATTACH(mp, tdp, 0);
		if (error)
		goto std_return;

Admin message