Commit cb30e029 authored by Mike Tipton's avatar Mike Tipton Committed by Georgi Djakov
Browse files

interconnect: qcom: Add support for per-BCM scaling factors 



Currently, bcm-voter always assumes requests are made in KBps and that
BCM HW always wants them in Bps, so it always scales the requests by
1000. However, certain use cases and BCMs may use different units.
Thus, add support for BCM-specific scaling factors.

Signed-off-by: default avatarMike Tipton <mdtipton@codeaurora.org>
Link: https://lore.kernel.org/r/20200903192149.30385-7-mdtipton@codeaurora.org


Signed-off-by: default avatarGeorgi Djakov <georgi.djakov@linaro.org>
parent db474be2

drivers/interconnect/qcom/bcm-voter.c

+2 −2
Original line number Diff line number Diff line
@@ -85,10 +85,10 @@ static void bcm_aggregate(struct qcom_icc_bcm *bcm) 
			agg_peak[bucket] = max(agg_peak[bucket], temp);

		}



		temp = agg_avg[bucket] * 1000ULL;

		temp = agg_avg[bucket] * bcm->vote_scale;

		bcm->vote_x[bucket] = bcm_div(temp, bcm->aux_data.unit);



		temp = agg_peak[bucket] * 1000ULL;

		temp = agg_peak[bucket] * bcm->vote_scale;

		bcm->vote_y[bucket] = bcm_div(temp, bcm->aux_data.unit);

	}

drivers/interconnect/qcom/icc-rpmh.c

+3 −0
Original line number Diff line number Diff line
@@ -136,6 +136,9 @@ int qcom_icc_bcm_init(struct qcom_icc_bcm *bcm, struct device *dev) 
	INIT_LIST_HEAD(&bcm->list);

	INIT_LIST_HEAD(&bcm->ws_list);



	if (!bcm->vote_scale)

		bcm->vote_scale = 1000;



	/* Link Qnodes to their respective BCMs */

	for (i = 0; i < bcm->num_nodes; i++) {

		qn = bcm->nodes[i];

drivers/interconnect/qcom/icc-rpmh.h

+2 −0
Original line number Diff line number Diff line
@@ -80,6 +80,7 @@ struct qcom_icc_node { 
 * @addr: address offsets used when voting to RPMH

 * @vote_x: aggregated threshold values, represents sum_bw when @type is bw bcm

 * @vote_y: aggregated threshold values, represents peak_bw when @type is bw bcm

 * @vote_scale: scaling factor for vote_x and vote_y

 * @dirty: flag used to indicate whether the bcm needs to be committed

 * @keepalive: flag used to indicate whether a keepalive is required

 * @aux_data: auxiliary data used when calculating threshold values and
@@ -95,6 +96,7 @@ struct qcom_icc_bcm { 
	u32 addr;

	u64 vote_x[QCOM_ICC_NUM_BUCKETS];

	u64 vote_y[QCOM_ICC_NUM_BUCKETS];

	u64 vote_scale;

	bool dirty;

	bool keepalive;

	struct bcm_db aux_data;

CRA Git | Maintained and supported by SUSTech CRA and CCSE