Commit caffcdd8 authored Apr 30, 2014 by Dietmar Eggemann Committed by Ingo Molnar May 22, 2014

sched: Do not zero sg->cpumask and sg->sgp->power in build_sched_groups()



There is no need to zero struct sched_group member cpumask and struct
sched_group_power member power since both structures are already allocated
as zeroed memory in __sdt_alloc().

This patch has been tested with
BUG_ON(!cpumask_empty(sched_group_cpus(sg))); and BUG_ON(sg->sgp->power);
in build_sched_groups() on ARM TC2 and INTEL i5 M520 platform including
CPU hotplug scenarios.

Signed-off-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1398865178-12577-1-git-send-email-dietmar.eggemann@arm.com


Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent c515db8c

kernel/sched/core.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -5794,8 +5794,6 @@ build_sched_groups(struct sched_domain *sd, int cpu)
		continue;

		group = get_group(i, sdd, &sg);
		cpumask_clear(sched_group_cpus(sg));
		sg->sgp->power = 0;
		cpumask_setall(sched_group_mask(sg));

		for_each_cpu(j, span) {

Admin message