Commit caec4e8d authored Jun 12, 2007 by Benjamin Herrenschmidt Committed by Linus Torvalds Jun 18, 2007

Fix signalfd interaction with thread-private signals



Don't let signalfd dequeue private signals off other threads (in the
case of things like SIGILL or SIGSEGV, trying to do so would result
in undefined behaviour on who actually gets the signal, since they
are force unblocked).

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Acked-by: Davide Libenzi <davidel@xmailserver.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent bd197234

kernel/signal.c

+7 −1

Original line number	Diff line number	Diff line
		@@ -363,7 +363,13 @@ static int __dequeue_signal(struct sigpending pending, sigset_t mask,
		*/
		int dequeue_signal(struct task_struct tsk, sigset_t mask, siginfo_t *info)
		{
		int signr = __dequeue_signal(&tsk->pending, mask, info);
		int signr = 0;

		/* We only dequeue private signals from ourselves, we don't let
		* signalfd steal them
		*/
		if (tsk == current)
		signr = __dequeue_signal(&tsk->pending, mask, info);
		if (!signr) {
		signr = __dequeue_signal(&tsk->signal->shared_pending,
		mask, info);

Admin message