tty: add missing newlines to WARN_RATELIMIT (cadf7486) · Commits · 戴 / test

WARN_RATELIMIT() expects the warning to end with a newline if one is needed. Not doing so results in odd looking warnings such as: [ 1339.454272] tty is NULLPid: 7147, comm: kworker/4:0 Tainted: G W 3.7.0-rc2-next-20121025-sasha-00001-g673f98e-dirty #75 Signed-off-by:

Sasha Levin <sasha.levin@oracle.com> Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/tty/n_tty.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -151,7 +151,7 @@ static void n_tty_set_room(struct tty_struct *tty)
		/* Did this open up the receive buffer? We may need to flip */
		if (left && !old_left) {
		WARN_RATELIMIT(tty->port->itty == NULL,
		"scheduling with invalid itty");
		"scheduling with invalid itty\n");
		schedule_work(&tty->port->buf.work);
		}
		}

drivers/tty/tty_buffer.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -473,7 +473,7 @@ static void flush_to_ldisc(struct work_struct *work)
		struct tty_ldisc *disc;

		tty = port->itty;
		if (WARN_RATELIMIT(tty == NULL, "tty is NULL"))
		if (WARN_RATELIMIT(tty == NULL, "tty is NULL\n"))
		return;

		disc = tty_ldisc_ref(tty);

Admin message