Commit cad12cde authored by Niklas Cassel's avatar Niklas Cassel Committed by Rafael J. Wysocki
Browse files

power: avs: qcom-cpr: fix unsigned expression compared with zero



drivers/power/avs/qcom-cpr.c:1539:5-21:
warning: unsigned expression compared with zero: drv->num_corners < 0

Reported-by: default avatarkbuild test robot <lkp@intel.com>
Reported-by: default avatarJulia Lawall <julia.lawall@lip6.fr>
Signed-off-by: default avatarNiklas Cassel <nks@flawful.org>
Reviewed-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent e808926b
Loading
Loading
Loading
Loading
+5 −3
Original line number Diff line number Diff line
@@ -1535,11 +1535,13 @@ static int cpr_pd_attach_dev(struct generic_pm_domain *domain,
	 * The reason for this is that we need to know the highest
	 * frequency associated with each fuse corner.
	 */
	drv->num_corners = dev_pm_opp_get_opp_count(&drv->pd.dev);
	if (drv->num_corners < 0) {
		ret = drv->num_corners;
	ret = dev_pm_opp_get_opp_count(&drv->pd.dev);
	if (ret < 0) {
		dev_err(drv->dev, "could not get OPP count\n");
		goto unlock;
	}
	drv->num_corners = ret;

	if (drv->num_corners < 2) {
		dev_err(drv->dev, "need at least 2 OPPs to use CPR\n");
		ret = -EINVAL;