Commit cac7172f authored May 03, 2020 by Sameeh Jubran Committed by David S. Miller May 03, 2020

net: ena: remove code that does nothing



Both key and func parameters are pointers on the stack.
Setting them to NULL does nothing.
The original intent was to leave the key and func unset in this case,
but for this to happen nothing needs to be done as the calling
function ethtool_get_rxfh() already clears key and func.

This commit removes the above described useless code.

Signed-off-by: Arthur Kiyanovski <akiyano@amazon.com>
Signed-off-by: Sameeh Jubran <sameehj@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 0af3c4e2

drivers/net/ethernet/amazon/ena/ena_ethtool.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -674,11 +674,8 @@ static int ena_get_rxfh(struct net_device netdev, u32 indir, u8 *key,
		*/
		rc = ena_com_get_hash_function(adapter->ena_dev, &ena_func);
		if (rc) {
		if (rc == -EOPNOTSUPP) {
		key = NULL;
		hfunc = NULL;
		if (rc == -EOPNOTSUPP)
		rc = 0;
		}

		return rc;
		}

Admin message